[FEATURE] Update l10n_state if translated values do not match #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case TCA allowLanguageSynchronization=1 is set the value of a translated record should be the same as the value in the default language, unless l10n_state contains a configuration for the field != "parent" (e.g. "custom"). In this case the value is inconsistent because "Use value from default language" is displayed in the BE, but the value is actually different. For better consistency, we change the configuration in l10n_state for these cases to "custom". Resolves: lolli42#97
If several fields are affected in one records, multiple UPDATEs in the DB would overwrite the previous change in l10n_state again. To fix this, the fields are now all bundled together and written in one UPDATE.
|
Hey Sybille. |
|
@lolli42 No worries, I already fixed this manually in our site so there is no pressure. Let me know if you need anything, e.g. to improve the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case TCA allowLanguageSynchronization=1 is set the value of a translated record should be the same as the value in the default language, unless l10n_state contains a configuration for the field != "parent" (e.g. "custom").
In this case the value is inconsistent because "Use value from default language" is displayed in the BE, but the value is actually different.
For better consistency, we change the configuration in l10n_state for these cases to "custom".
Resolves: #97