fix: mark form dirty when object keys are deleted #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4710 +/- ##
==========================================
+ Coverage 89.87% 89.90% +0.02%
==========================================
Files 93 93
Lines 7676 7695 +19
Branches 1360 1367 +7
==========================================
+ Hits 6899 6918 +19
Misses 770 770
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Fixes logaretm#4678 This fix has been co-authored by @SCBosch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔎 Overview
This PR fixes an issue where removed keys of objects in field values don't mark the form as dirty, because the
isEqualmethod is not commutative. Please refer to this comment for a demonstration of the issue: #4678 (comment).I read that a changeset was desired when submitting a PR, but I'm unsure what to include. Please advise.
✔ Issues affected
closes #4678
(Also credits to @SCBosch)