Fix: Validation not working when using model less validation with a default value. #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2355 +/- ##
==========================================
+ Coverage 95.14% 95.18% +0.04%
==========================================
Files 44 44
Lines 1029 1039 +10
Branches 152 154 +2
==========================================
+ Hits 979 989 +10
Misses 50 50
Continue to review full report at Codecov.
|
logaretm
approved these changes
Sep 20, 2019
This was referenced Sep 26, 2019
Merged
This was referenced Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit
The first commit is to fix the lint staged checks.
The test is removed because the _test function always returns an object. See:
vee-validate/src/validate.ts
Line 190 in 7041538
Second commit
See #2353 for the issue.
✔ Issues affected