Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infinite update loop if using vuetify v-radio-group and v-model with value "undefined" #2378

Closed
nicoschreiner opened this issue Sep 26, 2019 · 3 comments · Fixed by #2381
Closed
Labels
🐛 bug Unintended behavior

Comments

@nicoschreiner
Copy link

Versions

  • vee-validate: 3.0.7 (it's not in 3.0.6)
  • vue: 2.6.10
  • vuetify: 2.0.19

Describe the bug
You may have an infinite update loop in a component render function. if using vuetify v-radio-group in combination with ValidationProvider and v-model with value "undefined".

To reproduce
Steps to reproduce the behavior:

  1. Use a ValidationProvider with the rule "required" and add a v-radio-group with some v-radio inside.
  2. Set the v-model of v-radio-group to a value which is "undefined"

Expected behavior
Just an invalid validation of the ValidationProvider. Not an infinite loop.

Demo link
https://codesandbox.io/embed/vue-template-mptx0 (Open Developer-Console an click on "Toggle show")

Desktop:

  • OS: Windows 10
  • Browser: Chrome
  • Version: 76.0.3809.132

Additional context
Only in combination with vuetify, but not happening in Version 3.0.6 of vee-validate.

@logaretm
Copy link
Owner

Okay, this is caused by #2355 I will see what I can do

@logaretm logaretm added the 🐛 bug Unintended behavior label Sep 26, 2019
@logaretm logaretm mentioned this issue Sep 26, 2019
logaretm added a commit that referenced this issue Sep 26, 2019
* feat: handle different configuration for model value detection

* fix: improve early escape detection after finding model closes #2378
@nicoschreiner
Copy link
Author

@logaretm That was fast. Thank you! 😃

@logaretm
Copy link
Owner

@nicoschreiner You are welcome, 3.0.8 is up with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants