Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using options.numBackups instead of options.daysToKeep #78

Merged
merged 1 commit into from Jan 12, 2022

Conversation

lamweili
Copy link
Contributor

@lamweili lamweili commented Jan 12, 2022

Fixes log4js-node/log4js-node#1080, Fixes log4js-node/log4js-node#1035

It's renamed to numBackups instead for clarity while daysToKeep is still backward compatible.
Usage of daysToKeep will result in process.emitWarning of deprecation.

process.emitWarning(
"options.daysToKeep is deprecated due the confusion it causes when used " +
"together with file size rolling. Please use options.numBackups instead.",
"DeprecationWarning", "StreamRoller0001"
);

@lamweili lamweili added this to the 3.0.0 milestone Jan 12, 2022
@lamweili lamweili merged commit 07905fe into master Jan 12, 2022
@lamweili lamweili deleted the fix-daysToKeep-alias-numBackups branch January 12, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dateFile misleading parameter daysToKeep dateFile Appender daysToKeep not rolling by days
1 participant