Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add _writev again for batch write logs #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yss
Copy link

@yss yss commented Dec 30, 2019

It is better to add _writev function for batch write logs.

The most important point is the performance that improve the speed of log.

but also there will cause some unexpected results, like

  1. the size of log file may bigger that the maxSize when set maxSize config.
  2. may cause more memory usage.

Also, I saw the deleted pull request at #25.
And I fixed the failed test cases.

@nomiddlename
Copy link
Collaborator

Hi, thanks for this. I totally agree that _writev should be implemented, but the travis CI build is failing because there are no tests which use this code. How do you know that it works? Have you done some performance tests so see if this improves things? Looking at the code, I can't see that this will make much difference to memory usage or performance - but maybe I am missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants