Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: adding the option to provide appender instance in config #833

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

kaxelson
Copy link
Contributor

@kaxelson kaxelson commented Feb 4, 2019

This PR is related to issue #832.
It adds the ability to supply an appender instance (instead of just a string name) when specifying a configuration.

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #833 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #833   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files          25       25           
  Lines         937      937           
=======================================
  Hits          913      913           
  Misses         24       24
Impacted Files Coverage Δ
lib/appenders/index.js 95.91% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8221ada...efd5d2c. Read the comment docs.

@nomiddlename nomiddlename added this to the 4.4.0 milestone Jun 19, 2019
@nomiddlename nomiddlename merged commit e0abff4 into log4js-node:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants