Export Logger and LoggingEvent for easy customization #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: Export Logger and LoggingEvent so customization (like line numbers) can easily be implemented.
It's really useful to be able to see the originating file and line number when developing. I know this has performance impacts, but if the client code had access to the Logger and LoggingEvent objects, we could easily make that call on our own.
A simple example (abstracted from #73) shows how this could work in most smaller apps.
results in
It's a pretty trivial change (although it does expose internals) so I haven't written any tests, but I think any exposure to these two objects would suffice.
Thoughts?