Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update fakeFS.realpath as fs-extra uses it #1128

Merged
merged 1 commit into from Jan 14, 2022
Merged

test: update fakeFS.realpath as fs-extra uses it #1128

merged 1 commit into from Jan 14, 2022

Commits on Jan 14, 2022

  1. test: update fakeFS.read as graceful-fs uses it 

    `fs-extra@10.0.0` broke it as it removed the check for `fs.realpath.native`.

```diff
+L064 exports.realpath.native = u(fs.realpath.native)

-L126
-L127 // fs.realpath.native only available in Node v9.2+
-L128 if (typeof fs.realpath.native === 'function') {
-L129   exports.realpath.native = u(fs.realpath.native)
-L130 }
```
_(https://github.com/jprichardson/node-fs-extra/pull/887/files)_

When `fs.realpath` is an empty function, fs.realpath.native is `undefined`.

https://github.com/log4js-node/log4js-node/blob/25c17ad9802082d7a0fcf9c228cc5b99661e3ed9/test/tap/configuration-test.js#L17
    @lamweili
    lamweili committed Jan 14, 2022
    Copy the full SHA
    c226cb7 View commit details
    Browse the repository at this point in the history