test: update fakeFS.read as graceful-fs uses it #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceful-fs broke it as it changed to use `Object.setPrototypeOf(read, fs$read`). isaacs/node-graceful-fs@c55c1b8#diff-f740ecac46b2fdaa68156b133262813aa6f66218b11d8709bab83580e76e486dR136 What this means is that, if `fakeFS.read` is `undefined`, it throws an error as `Object.setPrototypeOf` doesn't accept `undefined` in its parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graceful-fs@4.2.5broke it as it changed to useObject.setPrototypeOf(read, fs$read).(isaacs/node-graceful-fs@c55c1b8#diff-f740ecac46b2fdaa68156b133262813aa6f66218b11d8709bab83580e76e486dR136)
When
fakeFS.readisundefined, it now throws an error asObject.setPrototypeOfdoesn't acceptundefinedin its parameters.