Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes file descriptor leak in certain use cases #1113

Merged
merged 6 commits into from Jan 17, 2022
Merged

Fixes file descriptor leak in certain use cases #1113

merged 6 commits into from Jan 17, 2022

Commits on Jan 4, 2022

  1. Added automated testing for file descriptor leak

    @lamweili
    lamweili committed Jan 4, 2022
    Copy the full SHA
    adbd369 View commit details
    Browse the repository at this point in the history

  2. Patched file descriptor leak by: 

    - subsequent log4js.configure() will run log4js.shutdown() first
- log4js.shutdown() will always clear/reset existing appenders and categories
    @lamweili
    lamweili committed Jan 4, 2022
    Copy the full SHA
    1e066b9 View commit details
    Browse the repository at this point in the history

  3. Improved code readability for shutdown() function

    @lamweili
    lamweili committed Jan 4, 2022
    Copy the full SHA
    44bf7ce View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Added automated test to assert appenders and categories are reverted … 

    …back to initial state on log4js.shutdown()
    @lamweili
    lamweili committed Jan 17, 2022
    Copy the full SHA
    2333054 View commit details
    Browse the repository at this point in the history

  2. Fixed ESLint arrow-body-style error

    @lamweili
    lamweili committed Jan 17, 2022
    Copy the full SHA
    c12ac23 View commit details
    Browse the repository at this point in the history

  3. Reduced setTimeout(1000) -> setTimeout(250) for waiting for file syst… 

    …em to catch up
    @lamweili
    lamweili committed Jan 17, 2022
    Copy the full SHA
    96f198b View commit details
    Browse the repository at this point in the history