feat: add evaluateArgsThatAreFunctions option #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelhameon
force-pushed
the
feat/evaluate-args-that-are-functions
branch
from
8c8078c
to
9bde721
Compare
gaelhameon
force-pushed
the
feat/evaluate-args-that-are-functions
branch
from
9bde721
to
aeb9404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to achieve the same functionality as #424
I tried adding the config parameter as discussed in #424, and I figured we might as well make it possible to define it for each category.
I did this the same way as what is currently done for the
useCallStackoption.I ended up implementing this in a different place than in #424: right in the logger, instead of in the layout.
Before I start writing tests, can you confirm:
In a way, I think it would actually make more sense to implement this in the layouts or the appenders, rather than in the categories, but for my use cases, a category based control works fine, and I don't really have the courage to get into the layouts / appenders code right now.