Merge pull request #1401 from MamfTheKramf/http-response-chaining

fix: enable method chaining for after writeHead
log4js-node · Apr 5, 2024 · bc59c87 · bc59c87
2 parents 4027fc7 + 24a6e36
commit bc59c87
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/lib/connect-logger.js b/lib/connect-logger.js
@@ -273,6 +273,7 @@ module.exports = function getLogger(logger4js, options) {
 
         res.__statusCode = code;
         res.__headers = headers || {};
+        return res;
       };
 
       // hook on end request to emit the log entry of the HTTP request.

diff --git a/test/tap/connect-context-test.js b/test/tap/connect-context-test.js
@@ -58,6 +58,7 @@ class MockResponse extends EE {
 
   writeHead(code /* , headers */) {
     this.statusCode = code;
+    return this;
   }
 }
 

diff --git a/test/tap/connect-logger-test.js b/test/tap/connect-logger-test.js
@@ -58,6 +58,7 @@ class MockResponse extends EE {
 
   writeHead(code /* , headers */) {
     this.statusCode = code;
+    return this;
   }
 }
 
@@ -87,8 +88,7 @@ function request(
     next = () => {};
   }
   cl(req, res, next);
-  res.writeHead(code, resHeaders);
-  res.end('chunk', 'encoding');
+  res.writeHead(code, resHeaders).end('chunk', 'encoding');
 }
 
 test('log4js connect logger', (batch) => {

diff --git a/test/tap/connect-nolog-test.js b/test/tap/connect-nolog-test.js
@@ -49,6 +49,7 @@ class MockResponse extends EE {
 
   writeHead(code /* , headers */) {
     this.statusCode = code;
+    return this;
   }
 }