Using regexp literal and .map instead of a loop for replacing

Signed-off-by: Cocoa <0xbbc@0xbbc.com>
log4js-node · May 7, 2020 · 40b5f09 · 40b5f09
1 parent b088498
commit 40b5f09
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/lib/appenders/file.js b/lib/appenders/file.js
@@ -55,12 +55,8 @@ function fileAppender(file, layout, logSize, numBackups, options, timezoneOffset
   const app = function (loggingEvent) {
     if (options.removeColor === true) {
       // eslint-disable-next-line no-control-regex
-      const regex = new RegExp("\x1b[[0-9;]*m", "g");
-      for (let i = 0; i < loggingEvent.data.length; i += 1) {
-        let d = loggingEvent.data[i];
-        d = d.replace(regex, '');
-        loggingEvent.data[i] = d;
-      }
+      const regex = /\x1b[[0-9;]*m/g;
+      loggingEvent.data = loggingEvent.data.map(d => d.replace(regex, ''))
     }
     if (!writer.write(layout(loggingEvent, timezoneOffset) + eol, "utf8")) {
       process.emit('log4js:pause', true);