New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: try native structuredClone
in cloneDeep
#5855
base: main
Are you sure you want to change the base?
Conversation
Instead of having skipNativeCheck as a parameter, it would be better to have an option object something like - It's more scalable, and descriptive |
The |
That works, I just figured using an object for a single option would be unnecessary (and I didn't see too many other uses of options for the other utilities). But the scalability argument makes sense and I'm open to making this change |
Yeah, the EDIT: Turns out this didn't work. not sure what the issue is, I can remove the lockfile changes on request |
79dcf39
to
ff2c89f
Compare
ff2c89f
to
eaf3fad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the yarn lock, but the rest looks good to me.
resolves lodash#5833 I tried to add tests but they don't seem to be running at the moment, this can be adjusted as necessary Any feedback on the proposed approach and any adjustments or additions is greatly appreciated. Additionally, insights on enhancing the implementation are welcome as well.
eaf3fad
to
02c4836
Compare
@jdalton I think this is good. Thoughts on the yarn lock? |
resolves #5833
I tried to add tests but they don't seem to be running at the moment, this can be adjusted as necessary
Any feedback on the proposed approach and any adjustments or additions is greatly appreciated. Additionally, insights on enhancing the implementation are welcome as well.