Throw exception when calling response.success()/.failure() if with-block has not been entered #1955

cyberw · 2021-12-08T09:26:07Z

For when catch_response=True is set, but someone forgot to do a with-block...

… without using a with block. Committing tests-first for validation.

…s() without using a with block (helps with some misunderstandings, e.g. #1953)

Throw exception if someone tries to call response.failure()/success()…

c79533d

… without using a with block. Committing tests-first for validation.

cyberw force-pushed the throw-exception-on-missing-with-block branch 3 times, most recently from 5c0b397 to 3499230 Compare December 8, 2021 10:30

Throw an exception if someone tries to call response.failure()/succes…

ceb2cf2

…s() without using a with block (helps with some misunderstandings, e.g. #1953)

cyberw force-pushed the throw-exception-on-missing-with-block branch from 3499230 to ceb2cf2 Compare December 8, 2021 10:42

cyberw added 2 commits December 8, 2021 11:51

Tests: Fix usage of assertRaises

409d4a6

fix test

0642063

cyberw merged commit 581e1de into master Dec 8, 2021

cyberw deleted the throw-exception-on-missing-with-block branch March 22, 2022 10:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Throw exception when calling response.success()/.failure() if with-block has not been entered #1955

Throw exception when calling response.success()/.failure() if with-block has not been entered #1955

cyberw commented Dec 8, 2021 •

edited

Throw exception when calling response.success()/.failure() if with-block has not been entered #1955

Throw exception when calling response.success()/.failure() if with-block has not been entered #1955

Conversation

cyberw commented Dec 8, 2021 • edited

cyberw commented Dec 8, 2021 •

edited