Stop declaring "fake" class level variables in Environment, User and StatsEntry #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stats. Do it in constructor/instance level, where they belong instead. The only benefit to having them on class level was so that they got documented properly, but it works as long as they are definied in __init__ as well. While this shouldnt be a breaking change for any "normal" usage of Locust, I think we need to do some testing to ensure that we dont need to bump major version. Added some type hints as well.
cyberw
changed the title
cyberw
force-pushed
the
remove-fake-class-level-variables-from-Environment-and-Users
branch
from
9fe3e83
to
5d84379
Compare
cyberw
deleted the
remove-fake-class-level-variables-from-Environment-and-Users
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do it in constructor/instance level, where they belong instead.
The only benefit to having them on class level was so that they got documented properly, but it works as long as they are definied in init as well.
While this shouldnt be a breaking change for any "normal" usage of Locust, I think we need to do some testing to ensure that we dont need to bump major version.
Added some type hints as well.