Skip to content

Commit

Permalink
remove dependency to cfn-lint to save disk space (#50)
Browse files Browse the repository at this point in the history
  • Loading branch information
whummer authored and viren-nadkarni committed Jul 4, 2022
1 parent 4ce0971 commit b0b85c1
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 4 deletions.
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@ terraformtests:
cd tests/terraformtests && bin/run_go_test $(SERVICE_NAME) "$(TEST_NAMES)"

publish:
python setup.py sdist bdist_wheel
twine upload dist/*
. .venv/bin/activate; \
python setup.py sdist bdist_wheel; \
twine upload dist/*

test_server:
@TEST_SERVER_MODE=true pytest -sv --cov=moto --cov-report xml ./tests/
Expand Down
2 changes: 1 addition & 1 deletion moto/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def __exit__(self, *exc):
# logging.getLogger('boto').setLevel(logging.CRITICAL)

__title__ = "moto"
__version__ = "3.1.9"
__version__ = "3.1.10"


try:
Expand Down
8 changes: 7 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ def get_version():
_dep_jsondiff,
_dep_aws_xray_sdk,
_dep_idna,
_dep_cfn_lint,
# removing cfn-lint for now, to save ~138MB
# _dep_cfn_lint,
_dep_sshpubkeys,
_dep_pyparsing,
_dep_openapi,
Expand All @@ -89,6 +90,11 @@ def get_version():
"appsync": [_dep_graphql],
"awslambda": [_dep_docker],
"batch": [_dep_docker],
"cloudformation": [
_dep_docker, _dep_PyYAML,
# removing cfn-lint for now, to save ~138MB
# _dep_cfn_lint
],
"cognitoidp": [_dep_python_jose, _dep_python_jose_ecdsa_pin],
"ec2": [_dep_sshpubkeys],
"glue": [_dep_pyparsing],
Expand Down
4 changes: 4 additions & 0 deletions tests/test_cloudformation/test_validate.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import boto3
import botocore
import sure # noqa # pylint: disable=unused-import
import pytest

from moto import mock_cloudformation, mock_s3
from tests import EXAMPLE_AMI_ID
Expand Down Expand Up @@ -41,6 +42,9 @@
dummy_template_json = json.dumps(json_template)
dummy_bad_template_json = json.dumps(json_bad_template)

# skip tests in this module, as we skip importing cfn-lint
pytestmark = pytest.mark.skip()


@mock_cloudformation
def test_boto3_json_validate_successful():
Expand Down

0 comments on commit b0b85c1

Please sign in to comment.