Adjust patches and cdklocal script for esbuild bundled package #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschubert
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust patches and
cdklocalscript for esbuild bundled package. Addresses #59The CDK build has recently (v2.14.0 and above) switched from a regular build with runtime
dependenciesto a packaged build usingesbuild. More details here: aws/aws-cdk#18667This PR separates the patches from the code imports, splits up the patches into separate functions, and then passes the imported libs to the patch functions. This allows us to apply the patches to v2.14.0+, as well as use a fallback mechanism for older CDK versions.