Upgrade gems due to a security bug fix in Nokigiri #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and general feature enhancements. Note: commonmarker ~> 0.18.0 currently breaks the app due to TypeError: option ':SAFE' does not exist for CommonMarker::Config::Render …hence the version pinning.
|
@pushcx I’ve created an independent PR for upgrading gem dependencies assuming that migrating to a new box will take longer so upgrading to Ruby 2.5.x is on hold until that happens as per Until then, this PR fixes potential security issue with Nokogiri dependent on which version of libxml2 is used by the gem. |
|
No worries, thanks for taking the initiative on this, especially with such a detailed writeup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and general feature enhancements.
More information can be found here:
Note: commonmarker ~> 0.18.0 currently breaks the app due to
TypeError: option ':SAFE' does not exist for CommonMarker::Config::Render
…hence the version pinning.