Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support this for additionalCustomNames #329

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

thatsmydoing
Copy link
Contributor

A ThisExpression doesn't have a name so effectively, this.it is parsed as undefined.it and that works but is obviously wrong since it would also catch literally undefined.it as well.

Copy link
Owner

@lo1tuma lo1tuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@lo1tuma lo1tuma merged commit 9fd40ea into lo1tuma:master Jul 20, 2022
@thatsmydoing thatsmydoing deleted the custom-this branch August 12, 2022 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants