Document recommended error level #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Problem
recommendedrules set includewarninganderrorlevel rules.Some team may rely on rules to prevent unwanted behavior, like the one addressed by
mocha/no-exclusive-tests.To make it work in CI, and not to rely on developer's local hooks, the default error level should be elevated from
warningtoerror. But to get this property, one has to dig into index.js馃 Solution
Add error level in rules documentation
馃寛 Remarks
Using emoticons may be more readable than text (maybe鈿狅笍 for
warningand 馃挘 forerror?)馃挴 Test
Compare with
index.js