Fix no-setup-in-describe to allow Mocha suite config #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule will now allow `this.timeout();`, `this.slow();`, and `this.retries();` in describe blocks, since they're configuration for the suite and not setup. Fixes lo1tuma#208.
lo1tuma
reviewed
Sep 9, 2019
| @@ -19,10 +19,16 @@ ruleTester.run('no-setup-in-describe', rule, { | |||
| 'it("", function () { a[b]; })', | |||
| 'it("", function () { a["b"]; })', | |||
| 'describe("", function () { it(); })', | |||
| 'describe("", function () { this.slow(1); it(); })', | |||
| 'describe("", function () { this.timeout(1); it(); })', | |||
| 'describe("", function () { this.retries(1); it(); })', | |||
There was a problem hiding this comment.
Can you add one test case with a computed member expression? E.g. this['retries'](1);
There was a problem hiding this comment.
My change to the rule doesn't allow for that form of the expression, so I added this to the invalid test cases, but lmk if you would rather I add support for that form in the rule!
There was a problem hiding this comment.
IMHO we should handle this case as well. There is already a function for that in ast utils: getPropertyName().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule will now allow
this.timeout();,this.slow();, andthis.retries();in describe blocks, since they're configuration forthe suite and not setup.
Fixes #208.