Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link necessary op interface implementations #3364

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

zjgarvey
Copy link
Collaborator

This patch adds two memref passes to torch-mlir-opt, which already occur in the pass pipeline torch-backend-to-linalg-on-tensors-backend-pipeline. Additionally, necessary op interface external models are included to address issue #3352.

Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also run into similar issues in the past. We have not been very strict about ensuring torch-mlir-opt has the right dependencies. Thanks for this fix!

lib/InitAll.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zjgarvey zjgarvey merged commit 56d21cb into llvm:main Jun 4, 2024
3 checks passed
penguin-wwy added a commit that referenced this pull request Jun 4, 2024
#3367 and #3364 introduced new dependencies, causing the [Bazel
workflow](https://github.com/llvm/torch-mlir/actions/workflows/bazelBuildAndTest.yml)
to fail. These need to be fixed in Bazel.
sjarus pushed a commit to sjarus/torch-mlir that referenced this pull request Jun 6, 2024
This patch adds two `memref` passes to `torch-mlir-opt`, which already
occur in the pass pipeline
`torch-backend-to-linalg-on-tensors-backend-pipeline`. Additionally,
necessary op interface external models are included to address issue
llvm#3352.
sjarus pushed a commit to sjarus/torch-mlir that referenced this pull request Jun 6, 2024
llvm#3367 and llvm#3364 introduced new dependencies, causing the [Bazel
workflow](https://github.com/llvm/torch-mlir/actions/workflows/bazelBuildAndTest.yml)
to fail. These need to be fixed in Bazel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants