importer: fix usage after PyTorch update #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The most recent commit implements a rudimentary version of ScopeGuard that appears sufficient for our case, so I don't think we need to worry about licensing issues. |
Unless requested otherwise, PyTorch no longer installs most of the header files under the caffe2 directory (see pytorch/pytorch#87986). This breaks our importer code since we need to use the `MakeGuard()` function to execute statements in the event of exceptions. To fix this issue, this patch implements a rudimentary version of PyTorch's ScopeGuard, where once the class variable goes out of scope, it executes a predefined method.
powderluv
approved these changes
Nov 4, 2022
silvasean
reviewed
Nov 7, 2022
| // RAII pattern to insert an operation before going out of scope. | ||
| class InserterGuard { | ||
| private: | ||
| MlirBlock _importBlock; |
There was a problem hiding this comment.
nit: no leading _ per style guide. Yes this is weird but it works :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless requested otherwise, PyTorch no longer installs most of the
header files under the caffe2 directory (see
pytorch/pytorch#87986). This breaks our
importer code since we need to use the
MakeGuard()function to executestatements in the event of exceptions.
To fix this issue, this patch implements a rudimentary version of
PyTorch's ScopeGuard, where once the class variable goes out of scope,
it executes a predefined method.