Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ctx_profile] Fix integration test when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=Off #92679

Closed
wants to merge 1 commit into from

Conversation

mtrofin
Copy link
Member

@mtrofin mtrofin commented May 19, 2024

When LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=Off the library name has the architecture part of its name. Just passing -lclang_rt.ctx_profile isn't sufficient, we need to append the suffix and also pass the lib dir.

(Follow-up from #92456)

@mgorny
Copy link
Member

mgorny commented May 19, 2024

Thanks. However, it seems that @vitalybuka already fixed it in 7fc524f.

@mtrofin mtrofin closed this May 19, 2024
@mtrofin mtrofin deleted the fix branch May 19, 2024 18:48
@mtrofin
Copy link
Member Author

mtrofin commented May 19, 2024

Thanks. However, it seems that @vitalybuka already fixed it in 7fc524f.

Oh! Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants