Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] parse: call decoder when parsing objects #479

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[New] parse: call decoder when parsing objects #479

wants to merge 2 commits into from

Conversation

nbgraham
Copy link

Fixes #284.

ljharb
ljharb requested changes Aug 5, 2023
View reviewed changes
lib/parse.js Outdated Show resolved Hide resolved
lib/parse.js Outdated Show resolved Hide resolved
test/parse.js Outdated Show resolved Hide resolved
test/parse.js Outdated Show resolved Hide resolved
test/parse.js Outdated Show resolved Hide resolved
@ljharb
Copy link
Owner

ljharb commented Aug 5, 2023

This seems like it's either a bugfix - a patch - or a breaking change, in which case it should be implemented behind an option instead.

@nbgraham @ljharb
Apply suggestions from code review
eb72cf4 
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@nbgraham
Copy link
Author

@ljharb
Based on this I was treating it as a bugfix. It's kinda already behind the decoder option. If you don't provide that, this won't do anything.
But I guess someone could be providing the decoder option today, and this could change the behavior for them.

@ljharb
Copy link
Owner

ljharb commented Aug 15, 2023

That's exactly my concern - especially since this issue was filed five years ago and the behavior probably long predates that.

Astrabacus

This comment was marked as spam.

Sign in to view

@Rizvy420 Rizvy420 mentioned this pull request Feb 27, 2024
Closed
@ljharb ljharb marked this pull request as draft February 28, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Astrabacus Astrabacus Astrabacus left review comments

@ljharb ljharb ljharb requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement parse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decoder function not being called
3 participants
@nbgraham @ljharb @Astrabacus