Rename formats.default to formats.defaultFormat #229
Conversation
such
changed the title
There was a problem hiding this comment.
I don't agree with this change; this is a bug in rollup, since "default" is a valid property on the single export that a CJS module has.
If Rollup can't work with a perfectly valid CJS module, then I'd suggest you take that into consideration when deciding if rollup is a viable tool or not.
(it looks like you aren't based on latest master, however, as you have a lot of unrelated changes in this PR)
dist/qs.js
Outdated
| if (!chain.length) { | ||
| return val; | ||
| } | ||
| var parseObject = function (chain, val, options) { |
There was a problem hiding this comment.
regardless, all of these changes where you removed function names would have to be reverted.
There was a problem hiding this comment.
I don't really understand where this change comes from... My changes in lib are restricted to the object of this PR...
There was a problem hiding this comment.
You might be rebased on a much older version of master?
There was a problem hiding this comment.
Oh, also, the dist file should never be updated except during a release :-) you can just revert this whole file.
|
iirc it is not an issue at all. rollup checks for __esModule variable. I created #230 to address what really confuse rollup. |
|
@btd you'll want to file a separate bug on rollup for that, then; a module bundler that doesn't understand a basic module format is broken. I'm going to close this; tools should serve code, not the other way around. |
Having an attribute named 'default' confuses rollup when packaging.
See rollup/rollup#1135 for instance.