Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show benchmarking for array combine stuff #187

Closed
wants to merge 2 commits into from

Conversation

elidoran
Copy link
Contributor

I made this PR separate from #185 because it's not my intent to add this stuff to master. Instead, I'm providing it just to mess with in its own branch.

Provides a new directory, benchmark/, with a script to benchmark different array combination implementations.

Adds dev dependencies:

  1. benchmark
  2. console.table
  3. comma-number

Run benchmark via:

node benchmark/arraying.js

Copy link
Owner

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, I'm happy to merge this into the project as long as all the important scripts can be run via npm run-script. no big deal either way.

require('console.table')

var comma = require('comma-number')
, Benchmark = require('benchmark')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comma last, please :-)

@elidoran elidoran mentioned this pull request Dec 22, 2016
@elidoran elidoran closed this Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants