Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to sort the keys in the query string FIX #64 #120

Merged
merged 1 commit into from Oct 7, 2015

Conversation

bobylito
Copy link

This option is needed when we want to create predictable query strings.

@bobylito
Copy link
Author

bobylito commented Oct 1, 2015

Hi @nlf could you review this PR? :)

@nlf nlf added the enhancement label Oct 1, 2015
@nlf nlf self-assigned this Oct 1, 2015
@nlf
Copy link
Collaborator

nlf commented Oct 1, 2015

I'll try to get to this today

@bobylito
Copy link
Author

bobylito commented Oct 1, 2015

Thanks!

@nlf nlf added this to the 5.2.0 milestone Oct 7, 2015
nlf added a commit that referenced this pull request Oct 7, 2015
Add an option to sort the keys in the query string FIX #64
@nlf nlf merged commit 98f0abc into ljharb:master Oct 7, 2015
@bobylito
Copy link
Author

bobylito commented Oct 8, 2015

Great :)

@codeclown
Copy link
Contributor

Is this mentioned in the docs at all?

@ljharb
Copy link
Owner

ljharb commented Dec 22, 2016

@codeclown a PR to flesh out the docs is always welcome

@codeclown
Copy link
Contributor

@ljharb Sure! #191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants