Change exports usage #230
Merged
Change exports usage #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Oct 14, 2017
There was a problem hiding this comment.
I'm not going to use rollup; it violates the spec. Similarly, if it can't understand exports. syntax - a CJS standard for years - that's a pretty massive flaw with it.
That said, using exports is definitely a bad practice anyways, and this is a good change. Thanks!
|
Yep, i understand what you mean. Thank you for merging. |
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
free
exportsusage (when it is not assignmnet for really exporting something) confusing rollup to wrap such modules in additional wrappers.This PR remove
exportsfor self referencing exporting symbols.Thanks.
What do you think about replacing build with rollup (i mean dist/qs.js) - it will produce smaller file, and much readable/debuggable? (i can prepare PR)