[Fix] require-default-props: avoid crash from jsx-eslint#3064

Fixes jsx-eslint#3068. Fixes jsx-eslint#3069
ljharb · Sep 5, 2021 · c1c284f · c1c284f
1 parent 230ffe1
commit c1c284f
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 3 deletions.
diff --git a/lib/rules/require-default-props.js b/lib/rules/require-default-props.js
@@ -60,6 +60,9 @@ module.exports = {
 
       Object.keys(propTypes).forEach((propName) => {
         const prop = propTypes[propName];
+        if (!prop.node) {
+          return;
+        }
         if (prop.isRequired) {
           if (forbidDefaultForRequired && defaultProps[propName]) {
             context.report({

diff --git a/tests/lib/rules/require-default-props.js b/tests/lib/rules/require-default-props.js
@@ -30,7 +30,7 @@ const ruleTester = new RuleTester({parserOptions});
 
 ruleTester.run('require-default-props', rule, {
 
-  valid: [
+  valid: [].concat(
     //
     // stateless components as function declarations
     {
@@ -1089,8 +1089,39 @@ ruleTester.run('require-default-props', rule, {
         };
       `,
       parser: parsers.BABEL_ESLINT
-    }
-  ],
+    },
+    parsers.TS([{
+      code: `
+        import React from "react";
+
+        interface Props {
+          name: string;
+        }
+        
+        const MyComponent: React.FC<Props> = ({ name }) => {
+          return <div>{name}</div>;
+        };
+        
+        export default MyComponent;
+      `,
+      parser: parsers.TYPESCRIPT_ESLINT
+    }, {
+      code: `
+        import React from "react";
+
+        interface Props {
+          name: string;
+        }
+        
+        const MyComponent: React.FC<Props> = ({ name }) => {
+          return <div>{name}</div>;
+        };
+        
+        export default MyComponent;
+      `,
+      parser: parsers['@TYPESCRIPT_ESLINT']
+    }])
+  ),
 
   invalid: [
     //