[Tests] make sure parsers.TS is harder to misuse

From jsx-eslint#2930 (comment)
ljharb · Feb 23, 2021 · af2d24a · af2d24a
1 parent 342ad24
commit af2d24a
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 11 deletions.
diff --git a/tests/helpers/parsers.js b/tests/helpers/parsers.js
@@ -11,6 +11,9 @@ module.exports = {
   TYPESCRIPT_ESLINT: path.join(__dirname, NODE_MODULES, 'typescript-eslint-parser'),
   '@TYPESCRIPT_ESLINT': path.join(__dirname, NODE_MODULES, '@typescript-eslint/parser'),
   TS: function TS(tests) {
+    if (!Array.isArray(tests) || arguments.length > 1) {
+      throw new SyntaxError('parsers.TS() takes a single array argument');
+    }
     if (semver.satisfies(version, '>= 5')) {
       return tests;
     }

diff --git a/tests/lib/rules/boolean-prop-naming.js b/tests/lib/rules/boolean-prop-naming.js
@@ -416,7 +416,7 @@ ruleTester.run('boolean-prop-naming', rule, {
       rule: '^is[A-Z]([A-Za-z0-9]?)+',
       validateNested: true
     }]
-  }, parsers.TS({
+  }, parsers.TS([{
     code: `
     type TestFNType = {
       isEnabled: boolean
@@ -428,7 +428,7 @@ ruleTester.run('boolean-prop-naming', rule, {
     }],
     parser: parsers['@TYPESCRIPT_ESLINT'],
     errors: []
-  })),
+  }])),
 
   invalid: [].concat({
     // createReactClass components with PropTypes
@@ -956,7 +956,7 @@ ruleTester.run('boolean-prop-naming', rule, {
       messageId: 'patternMismatch',
       data: {propName: 'something', pattern: '^is[A-Z]([A-Za-z0-9]?)+'}
     }]
-  }, parsers.TS({
+  }, parsers.TS([{
     code: `
     type TestConstType = {
       enabled: boolean
@@ -984,5 +984,5 @@ ruleTester.run('boolean-prop-naming', rule, {
     errors: [{
       message: 'Prop name (enabled) doesn\'t match rule (^is[A-Z]([A-Za-z0-9]?)+)'
     }]
-  }))
+  }]))
 });
diff --git a/tests/lib/rules/jsx-key.js b/tests/lib/rules/jsx-key.js
@@ -77,11 +77,11 @@ ruleTester.run('jsx-key', rule, {
     code: '[1, 2, 3]?.map(x => <BabelEslintApp />)',
     parser: parsers.BABEL_ESLINT,
     errors: [{messageId: 'missingIterKey'}]
-  }, parsers.TS({
+  }, parsers.TS([{
     code: '[1, 2, 3]?.map(x => <TypescriptEslintApp />)',
     parser: parsers['@TYPESCRIPT_ESLINT'],
     errors: [{messageId: 'missingIterKey'}]
-  }), {
+  }]), {
     code: '[1, 2, 3].map(x => <>{x}</>);',
     parser: parsers.BABEL_ESLINT,
     options: [{checkFragmentShorthand: true}],

diff --git a/tests/lib/rules/jsx-no-constructed-context-values.js b/tests/lib/rules/jsx-no-constructed-context-values.js
@@ -106,7 +106,7 @@ ruleTester.run('react-no-constructed-context-values', rule, {
         }
       `
     },
-    parsers.TS(
+    parsers.TS([
       {
         code: `
           import React from 'react';
@@ -141,12 +141,12 @@ ruleTester.run('react-no-constructed-context-values', rule, {
         `,
         parser: parsers['@TYPESCRIPT_ESLINT']
       }
-    ),
+    ]),
     {
       code: `
         import React from 'react';
         import BooleanContext from './BooleanContext';
-        
+
         function ContextProvider(props) {
             return (
                 <BooleanContext.Provider value>

diff --git a/tests/lib/rules/no-typos.js b/tests/lib/rules/no-typos.js
@@ -1856,7 +1856,7 @@ ruleTester.run('no-typos', rule, {
         parserOptions: parserOptions
       },
     */
-  }, parsers.TS({
+  }, parsers.TS([{
     code: `
       import 'prop-types'
     `,
@@ -1874,5 +1874,5 @@ ruleTester.run('no-typos', rule, {
     errors: [{
       messageId: 'noPropTypesBinding'
     }]
-  }))
+  }]))
 });