Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] pr inference #40

Merged
merged 1 commit into from Jan 6, 2022
Merged

[Fix] pr inference #40

merged 1 commit into from Jan 6, 2022

Conversation

Green-Ranger11
Copy link
Collaborator

@Green-Ranger11 Green-Ranger11 commented Jan 5, 2022

Search for sha does not include prs from forks and this PR will change can-merge to utilize GitHub's search api instead.

Closes #37
Closes #38

Copy link
Owner

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this seems to fix it on my local testing.

@Green-Ranger11
Copy link
Collaborator Author

Good to hear! Also, because we will now be using the search api I'm going to edit a few tests.

@ljharb
Copy link
Owner

ljharb commented Jan 5, 2022

yup, just noticed that in the GHA logs :-)

@Green-Ranger11
Copy link
Collaborator Author

Have also managed to find the fix for the incorrect status message when status is pending status checks.

@ljharb ljharb merged commit ba83be9 into main Jan 6, 2022
@ljharb ljharb deleted the fix/pr-inference branch January 6, 2022 00:04
ljharb added a commit that referenced this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can-merge incorrectly says the PR is mergeable PR inference is not working
2 participants