Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ModalHeader): Typo in ModalHeader interface #1091

Merged
merged 2 commits into from
May 21, 2024
Merged

fix(ModalHeader): Typo in ModalHeader interface #1091

merged 2 commits into from
May 21, 2024

Conversation

jpyzio123
Copy link
Contributor

Resolves: #1090

Description

Fixes typo that prevents setting custom className to ModalHeader component

Storybook

https://feature-1090--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@jpyzio123 jpyzio123 added the bug Something isn't working label Apr 26, 2024
@marcinsawicki marcinsawicki added this to the v1.0 milestone May 20, 2024
VadymBezpalko
VadymBezpalko approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@VadymBezpalko VadymBezpalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@VadymBezpalko VadymBezpalko changed the title Typo in ModalHeader interface fix(ModalHeader): Typo in ModalHeader interface May 21, 2024
@marcinsawicki marcinsawicki merged commit 49518a0 into main May 21, 2024
5 checks passed
@marcinsawicki marcinsawicki deleted the feature/modal-props-typo branch May 21, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VadymBezpalko VadymBezpalko VadymBezpalko approved these changes

@marcinsawicki marcinsawicki marcinsawicki approved these changes

@vladko-uxds vladko-uxds Awaiting requested review from vladko-uxds

Assignees
No one assigned
Labels
bug Something isn't working
Projects
LiveChat Design System
Status: Done
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

[BUG] Typo in ModalHeader interface
3 participants
@jpyzio123 @VadymBezpalko @marcinsawicki