Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer no-std url crate #2611

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Prefer no-std url crate #2611

merged 6 commits into from
Mar 25, 2024

Conversation

Kailai-Wang
Copy link
Collaborator

Context

IMO we should always prefer the no-std version of a crate over sgx-ported one.

This PR tries to replace url-sgx with a no-std rust-url crate (a forked one).

Please note in some scenarios where a IntoClientRequest is expected (e.g. tungstenite.client_tls_with_config) we are using the &str that has to include scheme. It's because Url to SocketAddress conversion is only possible under std. cc @kziemianek

We should be able to switch to the more "standard" crate once core::net is supported, see servo/rust-url#831 (comment)

It removes some unused code/import and renames the stf-task-sender a bit too - I think the path core/stf-task/sender/src/stf_task_sender.rs makes little sense when we include stf_task_sender twice

@Kailai-Wang Kailai-Wang self-assigned this Mar 22, 2024
@Kailai-Wang Kailai-Wang requested review from kziemianek and a team March 23, 2024 18:21
Copy link
Member

@kziemianek kziemianek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree that we should prefer no std crates over std/sgx.
I hope we will be able to switch to url from crates soon :)

@Kailai-Wang Kailai-Wang merged commit 827ad7c into dev Mar 25, 2024
25 of 26 checks passed
@Kailai-Wang Kailai-Wang deleted the use-no-std-url branch March 25, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants