Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
IMO we should always prefer the no-std version of a crate over sgx-ported one.
This PR tries to replace
url-sgx
with a no-stdrust-url
crate (a forked one).Please note in some scenarios where a
IntoClientRequest
is expected (e.g.tungstenite.client_tls_with_config
) we are using the&str
that has to include scheme. It's becauseUrl
toSocketAddress
conversion is only possible understd
. cc @kziemianekWe should be able to switch to the more "standard" crate once
core::net
is supported, see servo/rust-url#831 (comment)It removes some unused code/import and renames the
stf-task-sender
a bit too - I think the pathcore/stf-task/sender/src/stf_task_sender.rs
makes little sense when we includestf_task_sender
twice