Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change classMap to set classes correctly for SVGs #932

Merged
merged 8 commits into from Jun 14, 2019
Merged

Change classMap to set classes correctly for SVGs #932

merged 8 commits into from Jun 14, 2019

Commits on May 23, 2019

  1. Change classMap to set classes correctly for SVGs 

    The assignment to `element.className` in `classMap` was causing the
error `setting getter-only property "className"`.

According to [the SVG
specification](https://www.w3.org/TR/SVG11/types.html#InterfaceSVGStylable),
`className` is a read-only property. This differs from [`className` on
Element](https://developer.mozilla.org/en-US/docs/Web/API/Element/className),
which can be set.
    @AdamVig
    AdamVig committed May 23, 2019
    Copy the full SHA
    3ae0fff View commit details
    Browse the repository at this point in the history

  2. fixup! Change classMap to set classes correctly for SVGs

    @AdamVig
    AdamVig committed May 23, 2019
    Copy the full SHA
    a64d144 View commit details
    Browse the repository at this point in the history

  3. fixup! Change classMap to set classes correctly for SVGs

    @AdamVig
    AdamVig committed May 23, 2019
    Copy the full SHA
    3b1dd28 View commit details
    Browse the repository at this point in the history

  4. fixup! Change classMap to set classes correctly for SVGs

    @AdamVig
    AdamVig committed May 23, 2019
    Copy the full SHA
    47e2f6c View commit details
    Browse the repository at this point in the history

  5. fixup! Change classMap to set classes correctly for SVGs

    @AdamVig
    AdamVig committed May 23, 2019
    Copy the full SHA
    a1fa3dd View commit details
    Browse the repository at this point in the history

  6. Revert "fixup! Change classMap to set classes correctly for SVGs" 

    This reverts commits 47e2f6c and
a1fa3dd.
    @AdamVig
    AdamVig committed May 23, 2019
    Copy the full SHA
    71bc474 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2019

  1. fixup! Change classMap to set classes correctly for SVGs

    @AdamVig
    AdamVig committed Jun 14, 2019
    Copy the full SHA
    db4b931 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into fix-class-map-svg-c… 

    …ompat
    @AdamVig
    AdamVig committed Jun 14, 2019
    Copy the full SHA
    e039fba View commit details
    Browse the repository at this point in the history