Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ref value is always undefined when disconnected #4646

Merged
merged 3 commits into from May 23, 2024
Merged

Conversation

sorvell
Copy link
Member

@sorvell sorvell commented May 12, 2024

Fixes #4622

Copy link

changeset-bot bot commented May 12, 2024

🦋 Changeset detected

Latest commit: 7742fbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
lit-element Patch
lit-html Patch
lit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 12, 2024

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +2% (-0.66ms - +0.17ms)
    this-change vs tip-of-tree

render

  • this-change: 46.23ms - 48.84ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +5% (-0.12ms - +0.91ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.60ms - +0.52ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +1% (-0.92ms - +0.26ms)
    this-change vs tip-of-tree

update

  • this-change: 465.08ms - 475.65ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +7% (-1.84ms - +2.65ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.77ms - +2.24ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-3.96ms - +6.06ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 473.21ms - 479.64ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +2% (-1.67ms - +8.98ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
47.74ms - 49.96ms-

update

VersionAvg timevs
479.45ms - 490.48ms-

update-reflect

VersionAvg timevs
485.89ms - 494.19ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
18.61ms - 19.43ms-unsure 🔍
-1% - +5%
-0.16ms - +0.94ms
slower ❌
0% - 6%
0.09ms - 1.17ms
tip-of-tree
tip-of-tree
18.26ms - 19.00msunsure 🔍
-5% - +1%
-0.94ms - +0.16ms
-unsure 🔍
-1% - +4%
-0.27ms - +0.75ms
previous-release
previous-release
18.03ms - 18.74msfaster ✔
1% - 6%
0.09ms - 1.17ms
unsure 🔍
-4% - +1%
-0.75ms - +0.27ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
36.11ms - 39.77ms-unsure 🔍
-5% - +8%
-1.97ms - +2.91ms
unsure 🔍
-2% - +12%
-0.62ms - +4.16ms
tip-of-tree
tip-of-tree
35.85ms - 39.08msunsure 🔍
-8% - +5%
-2.91ms - +1.97ms
-unsure 🔍
-3% - +10%
-0.93ms - +3.52ms
previous-release
previous-release
34.64ms - 37.71msunsure 🔍
-11% - +1%
-4.16ms - +0.62ms
unsure 🔍
-9% - +2%
-3.52ms - +0.93ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.39ms - 10.97ms-unsure 🔍
-6% - +1%
-0.65ms - +0.16ms
unsure 🔍
-3% - +5%
-0.32ms - +0.54ms
tip-of-tree
tip-of-tree
10.64ms - 11.21msunsure 🔍
-2% - +6%
-0.16ms - +0.65ms
-unsure 🔍
-1% - +7%
-0.07ms - +0.78ms
previous-release
previous-release
10.25ms - 10.88msunsure 🔍
-5% - +3%
-0.54ms - +0.32ms
unsure 🔍
-7% - +1%
-0.78ms - +0.07ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
33.80ms - 34.73ms-unsure 🔍
-2% - +2%
-0.56ms - +0.63ms
unsure 🔍
-1% - +2%
-0.47ms - +0.70ms
tip-of-tree
tip-of-tree
33.86ms - 34.60msunsure 🔍
-2% - +2%
-0.63ms - +0.56ms
-unsure 🔍
-1% - +2%
-0.43ms - +0.60ms
previous-release
previous-release
33.79ms - 34.51msunsure 🔍
-2% - +1%
-0.70ms - +0.47ms
unsure 🔍
-2% - +1%
-0.60ms - +0.43ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
70.35ms - 73.25ms-unsure 🔍
-2% - +3%
-1.59ms - +2.38ms
unsure 🔍
-3% - +3%
-2.02ms - +1.92ms
tip-of-tree
tip-of-tree
70.04ms - 72.76msunsure 🔍
-3% - +2%
-2.38ms - +1.59ms
-unsure 🔍
-3% - +2%
-2.35ms - +1.47ms
previous-release
previous-release
70.51ms - 73.19msunsure 🔍
-3% - +3%
-1.92ms - +2.02ms
unsure 🔍
-2% - +3%
-1.47ms - +2.35ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
31.97ms - 32.85ms-unsure 🔍
-1% - +3%
-0.22ms - +0.91ms
unsure 🔍
-1% - +2%
-0.37ms - +0.77ms
tip-of-tree
tip-of-tree
31.71ms - 32.42msunsure 🔍
-3% - +1%
-0.91ms - +0.22ms
-unsure 🔍
-2% - +1%
-0.65ms - +0.37ms
previous-release
previous-release
31.85ms - 32.58msunsure 🔍
-2% - +1%
-0.77ms - +0.37ms
unsure 🔍
-1% - +2%
-0.37ms - +0.65ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
478.25ms - 492.39ms-unsure 🔍
-1% - +3%
-3.94ms - +13.45ms
unsure 🔍
-1% - +2%
-6.81ms - +10.71ms
tip-of-tree
tip-of-tree
475.50ms - 485.63msunsure 🔍
-3% - +1%
-13.45ms - +3.94ms
-unsure 🔍
-2% - +1%
-10.04ms - +4.44ms
previous-release
previous-release
478.20ms - 488.54msunsure 🔍
-2% - +1%
-10.71ms - +6.81ms
unsure 🔍
-1% - +2%
-4.44ms - +10.04ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
523.05ms - 535.03ms-unsure 🔍
-1% - +2%
-6.82ms - +9.67ms
unsure 🔍
-1% - +2%
-6.97ms - +8.85ms
tip-of-tree
tip-of-tree
521.96ms - 533.27msunsure 🔍
-2% - +1%
-9.67ms - +6.82ms
-unsure 🔍
-2% - +1%
-8.15ms - +7.18ms
previous-release
previous-release
522.93ms - 533.27msunsure 🔍
-2% - +1%
-8.85ms - +6.97ms
unsure 🔍
-1% - +2%
-7.18ms - +8.15ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Contributor

The size of lit-html.js and lit-core.min.js are as expected.

Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions on the changeset

.changeset/violet-phones-look.md Outdated Show resolved Hide resolved
.changeset/violet-phones-look.md Outdated Show resolved Hide resolved
sorvell and others added 2 commits May 23, 2024 15:34
Co-authored-by: Augustine Kim <augustinekim@google.com>
Co-authored-by: Augustine Kim <augustinekim@google.com>
@sorvell sorvell merged commit abf30b3 into main May 23, 2024
9 checks passed
@sorvell sorvell deleted the ref-disconnected branch May 23, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ref should not provide element when disconnected
3 participants