Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In DEV_MODE, render a warning instead of rendering a template's host in the template. #3199

Merged
merged 2 commits into from Aug 5, 2022
Merged

In DEV_MODE, render a warning instead of rendering a template's host in the template. #3199

merged 2 commits into from Aug 5, 2022

Commits on Aug 5, 2022

  1. In DEV_MODE, render a warning instead of rendering a template's host … 

    …in the template.

Most commonly this would happen when rendering `${this}` in a LitElement's template, which has the counterintuitive behavior of removing the element from the DOM, because when rendering the element's template we attach it into its own shadow root, which removes it from the DOM, causing it simply disappear. This is especially problematic with a fast HMR system.
    @rictic
    rictic committed Aug 5, 2022
    Copy the full SHA
    3934bff View commit details
    Browse the repository at this point in the history

  2. Log a warning as well

    @rictic
    rictic committed Aug 5, 2022
    Copy the full SHA
    e215a65 View commit details
    Browse the repository at this point in the history