Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export StaticValue from lit-html/static #3186

Merged
merged 4 commits into from Jul 28, 2022
Merged

Export StaticValue from lit-html/static #3186

merged 4 commits into from Jul 28, 2022

Conversation

dfreedm
Copy link
Member

@dfreedm dfreedm commented Jul 28, 2022

Class properties initialized with a literal are implicitly typed as
any because StaticValue is not exported.

Class properties initialized with a literal are implicitly typed as
`any` because `StaticValue` is not exported.
@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2022

🦋 Changeset detected

Latest commit: 618465f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
lit-html Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -2% - +1% (-0.52ms - +0.38ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 71.99ms - 73.51ms
  • lit-html-kitchen-sink: unsure 🔍 -0% - +1% (-0.12ms - +0.30ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -5% - +2% (-0.56ms - +0.24ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +1% (-0.44ms - +0.68ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -0% - +2% (-0.10ms - +1.17ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 682.10ms - 688.75ms
  • lit-html-kitchen-sink: unsure 🔍 -2% - +3% (-1.58ms - +2.09ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -10% - +4% (-29.12ms - +12.35ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +1% (-1.31ms - +1.04ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-6.54ms - +3.54ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 698.20ms - 703.50ms
  • reactive-element-list: unsure 🔍 -1% - +2% (-5.27ms - +12.63ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
71.99ms - 73.51ms-

update

VersionAvg timevs
682.10ms - 688.75ms-

update-reflect

VersionAvg timevs
698.20ms - 703.50ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
28.32ms - 28.62ms-unsure 🔍
-0% - +1%
-0.12ms - +0.30ms
unsure 🔍
-1% - +1%
-0.23ms - +0.22ms
tip-of-tree
tip-of-tree
28.23ms - 28.53msunsure 🔍
-1% - +0%
-0.30ms - +0.12ms
-unsure 🔍
-1% - +0%
-0.32ms - +0.14ms
previous-release
previous-release
28.30ms - 28.65msunsure 🔍
-1% - +1%
-0.22ms - +0.23ms
unsure 🔍
-0% - +1%
-0.14ms - +0.32ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
77.68ms - 80.27ms-unsure 🔍
-2% - +3%
-1.58ms - +2.09ms
unsure 🔍
-1% - +3%
-0.92ms - +2.43ms
tip-of-tree
tip-of-tree
77.42ms - 80.02msunsure 🔍
-3% - +2%
-2.09ms - +1.58ms
-unsure 🔍
-2% - +3%
-1.18ms - +2.18ms
previous-release
previous-release
77.16ms - 79.29msunsure 🔍
-3% - +1%
-2.43ms - +0.92ms
unsure 🔍
-3% - +1%
-2.18ms - +1.18ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
25.93ms - 26.49ms-unsure 🔍
-2% - +1%
-0.52ms - +0.38ms
unsure 🔍
-1% - +2%
-0.36ms - +0.40ms
tip-of-tree
tip-of-tree
25.93ms - 26.64msunsure 🔍
-1% - +2%
-0.38ms - +0.52ms
-unsure 🔍
-1% - +2%
-0.35ms - +0.53ms
previous-release
previous-release
25.94ms - 26.45msunsure 🔍
-2% - +1%
-0.40ms - +0.36ms
unsure 🔍
-2% - +1%
-0.53ms - +0.35ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.26ms - 10.81ms-unsure 🔍
-5% - +2%
-0.56ms - +0.24ms
unsure 🔍
-4% - +3%
-0.40ms - +0.35ms
tip-of-tree
tip-of-tree
10.40ms - 10.98msunsure 🔍
-2% - +5%
-0.24ms - +0.56ms
-unsure 🔍
-2% - +5%
-0.25ms - +0.51ms
previous-release
previous-release
10.31ms - 10.81msunsure 🔍
-3% - +4%
-0.35ms - +0.40ms
unsure 🔍
-5% - +2%
-0.51ms - +0.25ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
270.90ms - 291.54ms-unsure 🔍
-10% - +4%
-29.12ms - +12.35ms
unsure 🔍
-6% - +5%
-16.69ms - +14.00ms
tip-of-tree
tip-of-tree
271.62ms - 307.59msunsure 🔍
-4% - +10%
-12.35ms - +29.12ms
-unsure 🔍
-5% - +10%
-14.22ms - +28.31ms
previous-release
previous-release
271.21ms - 293.92msunsure 🔍
-5% - +6%
-14.00ms - +16.69ms
unsure 🔍
-10% - +5%
-28.31ms - +14.22ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
52.09ms - 52.95ms-unsure 🔍
-1% - +1%
-0.44ms - +0.68ms
unsure 🔍
-1% - +1%
-0.36ms - +0.73ms
tip-of-tree
tip-of-tree
52.03ms - 52.77msunsure 🔍
-1% - +1%
-0.68ms - +0.44ms
-unsure 🔍
-1% - +1%
-0.43ms - +0.56ms
previous-release
previous-release
52.00ms - 52.67msunsure 🔍
-1% - +1%
-0.73ms - +0.36ms
unsure 🔍
-1% - +1%
-0.56ms - +0.43ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
108.14ms - 109.82ms-unsure 🔍
-1% - +1%
-1.31ms - +1.04ms
unsure 🔍
-1% - +1%
-1.20ms - +0.97ms
tip-of-tree
tip-of-tree
108.29ms - 109.95msunsure 🔍
-1% - +1%
-1.04ms - +1.31ms
-unsure 🔍
-1% - +1%
-1.05ms - +1.10ms
previous-release
previous-release
108.41ms - 109.78msunsure 🔍
-1% - +1%
-0.97ms - +1.20ms
unsure 🔍
-1% - +1%
-1.10ms - +1.05ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
54.22ms - 55.08ms-unsure 🔍
-0% - +2%
-0.10ms - +1.17ms
unsure 🔍
-2% - +1%
-0.90ms - +0.57ms
tip-of-tree
tip-of-tree
53.65ms - 54.58msunsure 🔍
-2% - +0%
-1.17ms - +0.10ms
-unsure 🔍
-3% - +0%
-1.46ms - +0.05ms
previous-release
previous-release
54.22ms - 55.41msunsure 🔍
-1% - +2%
-0.57ms - +0.90ms
unsure 🔍
-0% - +3%
-0.05ms - +1.46ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
680.66ms - 686.80ms-unsure 🔍
-1% - +1%
-6.54ms - +3.54ms
unsure 🔍
-2% - +1%
-13.93ms - +5.54ms
tip-of-tree
tip-of-tree
681.24ms - 689.23msunsure 🔍
-1% - +1%
-3.54ms - +6.54ms
-unsure 🔍
-2% - +1%
-12.75ms - +7.37ms
previous-release
previous-release
678.69ms - 697.16msunsure 🔍
-1% - +2%
-5.54ms - +13.93ms
unsure 🔍
-1% - +2%
-7.37ms - +12.75ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
789.62ms - 798.44ms-unsure 🔍
-1% - +2%
-5.27ms - +12.63ms
unsure 🔍
-1% - +1%
-6.58ms - +8.47ms
tip-of-tree
tip-of-tree
782.56ms - 798.14msunsure 🔍
-2% - +1%
-12.63ms - +5.27ms
-unsure 🔍
-2% - +1%
-12.63ms - +7.16ms
previous-release
previous-release
786.99ms - 799.19msunsure 🔍
-1% - +1%
-8.47ms - +6.58ms
unsure 🔍
-1% - +2%
-7.16ms - +12.63ms
-

tachometer-reporter-action v2 for Benchmarks

packages/lit/src/index.all.ts Outdated Show resolved Hide resolved
.changeset/hip-eels-ring.md Outdated Show resolved Hide resolved
.changeset/hip-eels-ring.md Outdated Show resolved Hide resolved
packages/lit/src/index.all.ts Outdated Show resolved Hide resolved
Co-authored-by: Augustine Kim <augustinekim@google.com>
packages/lit/src/index.all.ts Outdated Show resolved Hide resolved
@dfreedm dfreedm merged commit 3766ae4 into main Jul 28, 2022
@dfreedm dfreedm deleted the export-static-value branch July 28, 2022 23:11
@lit-robot lit-robot mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants