New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Lit core pre-releases to test #3156 #3173
Conversation
🦋 Changeset detectedLatest commit: 22108df The changes in this PR will be included in the next version bump. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Things getting next.0
release are: lit
, lit-html
, lit-element
, @lit/reactive-element
.
Pipeline failing to npm ci
is unfortunate. I suppose if this was made without ignoring anything it would've worked, but you probably already have dependencies installed on your machine so I'll assume this is a non-issue.
Closing as #3156 has been successfully merged and released |
Pre-releases of Lit core libraries for testing #3156.
NOTE: I don't intend to merge this PR; instead I will do the release manually from my workstation after approval. If there are additional pre-releases to do for this feature, I'll push them to this PR and do another round of review. After the feature is merged (or abandoned), I'll close this PR.
Since #3156 is a fairly major new feature (adding node builds), which would be a breaking change if we were to remove, I'd like to first publish pre-releases to allow some folks to play around with it.
I think this is the first time we've done pre-releases using changesets. I used https://github.com/changesets/changesets/blob/main/docs/prereleases.md as a reference, and did the following:
npx changeset pre enter next
npx changeset version --ignore @lit-labs/cli --ignore @lit-internal/benchmarks --ignore @lit-labs/context --ignore @lit-labs/motion --ignore @lit-labs/observers --ignore @lit-labs/react --ignore @lit/localize --ignore @lit/localize-tools --ignore @lit/ts-transformers --ignore @lit-internal/localize-examples-runtime-js --ignore @lit-internal/localize-examples-runtime-ts --ignore @lit-internal/localize-examples-transform-js --ignore @lit-internal/localize-examples-transform-ts --ignore @lit-internal/test-element-a --ignore @lit-labs/router --ignore @lit-labs/testing --ignore @lit-labs/virtualizer --ignore @lit-labs/ssr --ignore @lit-labs/ssr-client --ignore @lit-labs/scoped-registry-mixin --ignore @lit-labs/router --ignore @lit-labs/ssr-client --ignore @lit-labs/eleventy-plugin-lit --ignore @lit/lit-starter-js --ignore @lit-labs/task --ignore @lit/lit-starter-ts
The big list of
--ignore
flags is to prevent publishing packages that depend on these pre-releases, because I don't think we need to do that.