Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core/ssr] Add Node builds that don't explode #3156

Merged
merged 14 commits into from Aug 4, 2022
Merged

[core/ssr] Add Node builds that don't explode #3156

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
463f5c3
Add ability to create node build in rollup config
aomarks Jul 20, 2022
951d379
Add node build to lit-html
aomarks Jul 20, 2022
a2e074a
Add node build to reactive-element
aomarks Jul 20, 2022
9515303
Add node test to lit-element. Does not need a node build
aomarks Jul 20, 2022
e759658
Add node test to lit. Does not need a node build
aomarks Jul 20, 2022
6d6ec28
Changeset
aomarks Jul 20, 2022
7df247b
Merge branch 'main' into explode
aomarks Jul 21, 2022
925b489
Comment about globalThis vs window in IE11
aomarks Jul 21, 2022
f7e8dc4
Merge branch 'main' into explode
aomarks Jul 21, 2022
9b05f30
Address PR comments
aomarks Jul 21, 2022
266af90
Temporarily shim HTMLElement in a sneakier way
aomarks Jul 21, 2022
56c0537
Merge branch 'main' into explode
aomarks Jul 25, 2022
19a8df3
Update version string replacer script
aomarks Jul 25, 2022
8367869
Merge branch 'main' into explode
aomarks Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/update-version-variables.js
View file
Open in desktop
Expand Up @@ -24,12 +24,12 @@ const updateVersionVariable = async (packageDir, sourcePath, variableName) => {

// Replace version number
const versionVarRegex = new RegExp(
`\\(globalThis\\.${variableName} \\?\\?= \\[\\]\\)\\.push\\('\\d+\\.\\d+\\.\\d+'\\)`
`(\\(global(?:This)?\\.${variableName} \\?\\?= \\[\\]\\)\\.push\\(')\\d+\\.\\d+\\.\\d+[^']*('\\))`
);
let replaced = false;
const newSource = fileSource.replace(versionVarRegex, () => {
const newSource = fileSource.replace(versionVarRegex, (_, pre, post) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh very nice utilization of capture groups.

replaced = true;
return `(globalThis.${variableName} ??= []).push('${version}')`;
return pre + version + post;
});
if (!replaced) {
throw new Error(`Version variable not found: ${filePath} ${variableName}`);
Expand Down