[reactive-element] Adds preserveExisting option to adoptStyles
#3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ability to add to an existing set of styles via adoptStyles. Fixes #3010.
🦋 Changeset detectedLatest commit: 4cff378 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultslit-element-list
render
update
update-reflect
lit-html-kitchen-sink
render
update
nop-update
lit-html-repeat
render
update
lit-html-template-heavy
render
update
reactive-element-list
render
update
update-reflect
|
| // If `supportsAdoptingStyleSheets` is true then we assume CSSStyleSheet is | ||
| // constructable. | ||
| if (supportsAdoptingStyleSheets && this._styleSheet === undefined) { | ||
| (this._styleSheet = new CSSStyleSheet()).replaceSync(this.cssText); |
There was a problem hiding this comment.
This is going to cause stylesheet duplication and css text re-parsing in some maybe still relatively common scenarios:
class BaseElement extends LitElement {
static get styles() { return css`...`; }
}
class SubElementA extends BaseElement {
static get styles() { return [BaseElement.styles, css`...`]; }
}There was a problem hiding this comment.
It will however give a speedup on codebases that don't use a getter for styles, like all TS codebases, due to skipping a hash of a potentially long string.
I wonder if we can split the difference by caching based on the TemplateStringsArray, but only when the length is 1, so there are no interpolations to worry about.
There was a problem hiding this comment.
This PR was based on #2978 and that change is made there, so let's discuss this change there?
There was a problem hiding this comment.
Oh yeah... I paused that one to consider what to do about getters.
added 6 commits
June 18, 2022 06:26
Tests adopting CSSStyleSheet and tests that we cover the case of using a constructed stylesheet when polyfilling via ShadyDOM/CSS.
|
We've decided not to land this. See #3010 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3010. Adds ability to add to an existing set of styles via
adoptStyles.Size delta:
main: 12.75 kB │ 6.49 kB │ 5.57 kB
preserve: 13.29 kB │ 6.73 kB │ 5.8 kB