New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #3028
Version Packages #3028
Conversation
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultslit-element-list
render
update
update-reflect
lit-html-kitchen-sink
render
update
nop-update
lit-html-repeat
render
update
lit-html-template-heavy
render
update
reactive-element-list
render
update
update-reflect
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two issues in this release PR.
- Private packages should not have changesets.
- Need to add a changeset entry for 5b4edbb
Agreed, private should not have changesets, or at least only have patch versions so we can release to public with 0.1.0.
|
7e84f0b
to
41ee9ba
Compare
It doesn't seem like the package-lock files were updated as I hoped this #2921 would do. May need further investigation but isn't a blocker to release. Also.. This PR doesn't have any test pipelines running? Is it because github-actions bot is the commit author on an update? But I don't see a button to even approve workflows to run, and without those running, this can't be merged. :/ |
18bf97c
to
23e4f3d
Compare
Force pushed to trigger workflows to run with following changes:
|
Perhaps it might be better to not include the empty changeset here, and loosen the requirement/override it. @aomarks could you help with that? |
23e4f3d
to
a3ad73a
Compare
a3ad73a
to
4b4d46d
Compare
|
||
- [#2979](https://github.com/lit/lit/pull/2979) [`09156025`](https://github.com/lit/lit/commit/0915602543cd211be19ffd2f54e0082df7ac5ea4) - Fixes `@contextProvider` when multiple instances of an element are created; updates docs to consistently reference `@contextProvided`. | ||
|
||
- [#2858](https://github.com/lit/lit/pull/2858) [`5b4edbb6`](https://github.com/lit/lit/commit/5b4edbb6b602f3c40034ebe629b94b2e51ac0c1e) - An element can now provide and request the same context. This lets elements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for fixing this @augustjk !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing it out in the first place!
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@lit-labs/context@0.1.2
Patch Changes
#2979
09156025
- Fixes@contextProvider
when multiple instances of an element are created; updates docs to consistently reference@contextProvided
.#3029
b373fccd
- An element can now provide and request the same context. This lets elementsredefine the context binding in terms of what was provided by the parent.
@lit-labs/react@1.0.5
Patch Changes
#2987
93b30f7d
- [labs/react]useController
is compatible with React strict mode.#2960
16a900c7
- Fix'@lit-labs/react/use-controller.js'
not being correctly exported from package.json.lit@2.2.6
Patch Changes
b12e8d93
- Expand documentation forrender
andTemplateResult
.lit-html@2.2.6
Patch Changes
b12e8d93
- Expand documentation forrender
andTemplateResult
.@lit/localize@0.11.3
Patch Changes
ee864b6d
- Fix multiple runtime msg call with same template but different expressions