Skip to content

Commit

Permalink
Rename internal packages to @lit-internal namespace (#3024)
Browse files Browse the repository at this point in the history
This PR renames all of our internal local-only packages, like internal-scripts and tests to be within the @lit-internal npm namespace, which I have just registered.

The internal-scripts package was recently discovered to be malware, see the notice at https://www.npmjs.com/package/internal-scripts.

This would never have affected users installing our packages in the normal way, since these are only devDependencies. It would also not affect our own normal development workflows, because lerna bootstrap knows to make a symlink for this local package, instead of installing from npm. However, it could have affected somebody who accidentally did cd packages/lit; npm install instead of lerna bootstrap.
  • Loading branch information
aomarks committed Jun 10, 2022
1 parent 1838cb8 commit e088732
Show file tree
Hide file tree
Showing 51 changed files with 62 additions and 60 deletions.
2 changes: 2 additions & 0 deletions .changeset/early-sheep-hear.md
@@ -0,0 +1,2 @@
---
---
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -62,7 +62,7 @@ lit-html 1.x source is available on the [`lit-html-1.x`](https://github.com/lit/
- Internal packages (not published to npm)
- [`tests`](./packages/tests) - Test infrastructure for the monorepo.
- [`benchmarks`](./packages/benchmarks) - Benchmarks for testing various libraries in the monorepo.
- [`internal-scripts`](./packages/internal-scripts) - Utility scripts used within the monorepo.
- [`@lit-internal/scripts`](./packages/@lit-internal/scripts) - Utility scripts used within the monorepo.

## Contributing to Lit

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
@@ -1,5 +1,5 @@
{
"name": "lit-monorepo",
"name": "@lit-internal/monorepo",
"private": true,
"type": "module",
"engines": {
Expand Down
2 changes: 1 addition & 1 deletion packages/benchmarks/CHANGELOG.md
@@ -1,4 +1,4 @@
# lit-benchmarks
# @lit-internal/benchmarks

## 1.0.2

Expand Down
2 changes: 1 addition & 1 deletion packages/benchmarks/generator/package.json
@@ -1,5 +1,5 @@
{
"name": "benchmarks",
"name": "@lit-internal/benchmarks-generator",
"version": "1.0.0",
"private": true,
"description": "Template benchmark generator",
Expand Down
4 changes: 2 additions & 2 deletions packages/benchmarks/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/benchmarks/package.json
@@ -1,5 +1,5 @@
{
"name": "lit-benchmarks",
"name": "@lit-internal/benchmarks",
"version": "1.0.2",
"private": true,
"description": "Benchmarks for lit",
Expand Down
4 changes: 2 additions & 2 deletions packages/internal-scripts/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/internal-scripts/package.json
@@ -1,12 +1,12 @@
{
"name": "internal-scripts",
"name": "@lit-internal/scripts",
"private": true,
"version": "1.0.0",
"description": "Internal scripts for the Lit monorepo",
"repository": {
"type": "git",
"url": "https://github.com/lit/lit.git",
"directory": "packages/internal-scripts"
"directory": "packages/@lit-internal/scripts"
},
"author": "Google LLC",
"license": "BSD-3-Clause",
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/cli/package.json
Expand Up @@ -96,7 +96,7 @@
"eslint": "^5.16.0",
"globby": "^10.0.2",
"stdout-stderr": "^0.1.13",
"tests": "^0.0.0",
"@lit-internal/tests": "^0.0.0",
"typescript": "~4.6.2",
"uvu": "^0.5.3"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/cli/src/test/gen/react_test.ts
Expand Up @@ -10,7 +10,7 @@ import * as assert from 'uvu/assert';
import {LitCli} from '../../lib/lit-cli.js';
import {suite} from '../uvu-wrapper.js';
import {TestConsole} from '../cli-test-utils.js';
import {FilesystemTestRig} from 'tests/utils/filesystem-test-rig.js';
import {FilesystemTestRig} from '@lit-internal/tests/utils/filesystem-test-rig.js';

interface TestContext {
testConsole: TestConsole;
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/cli/src/test/help_test.ts
Expand Up @@ -14,7 +14,7 @@ import {ReferenceToCommand} from '../lib/command.js';
import {ConsoleConstructorOptions} from 'console';
import * as stream from 'stream';
import {suite} from './uvu-wrapper.js';
import {FilesystemTestRig} from 'tests/utils/filesystem-test-rig.js';
import {FilesystemTestRig} from '@lit-internal/tests/utils/filesystem-test-rig.js';

interface TestContext {
console: TestConsole;
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/context/package.json
Expand Up @@ -142,7 +142,7 @@
"@web/test-runner-mocha": "^0.3.5",
"chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0",
"internal-scripts": "^1.0.0",
"@lit-internal/scripts": "^1.0.0",
"mocha": "^8.1.3",
"rollup": "^2.28.2",
"typescript": "^4.1.3"
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/gen-utils/package.json
Expand Up @@ -48,7 +48,7 @@
},
"devDependencies": {
"@types/node": "^17.0.31",
"tests": "^0.0.0",
"@lit-internal/tests": "^0.0.0",
"typescript": "~4.6.2",
"uvu": "^0.5.3"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/gen-utils/src/test/file-utils_test.ts
Expand Up @@ -7,7 +7,7 @@
import {suite} from 'uvu';
// eslint-disable-next-line import/extensions
import * as assert from 'uvu/assert';
import {FilesystemTestRig} from 'tests/utils/filesystem-test-rig.js';
import {FilesystemTestRig} from '@lit-internal/tests/utils/filesystem-test-rig.js';
import {writeFileTree} from '../lib/file-utils.js';

const writeFileTreeTest = suite<{tempFs: FilesystemTestRig}>('writeFileTree');
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/gen-utils/src/test/package-utils_test.ts
Expand Up @@ -12,7 +12,7 @@ import {
buildPackage,
packPackage,
} from '../lib/package-utils.js';
import {FilesystemTestRig} from 'tests/utils/filesystem-test-rig.js';
import {FilesystemTestRig} from '@lit-internal/tests/utils/filesystem-test-rig.js';

const test = suite<{tempFs: FilesystemTestRig}>('test');

Expand Down
2 changes: 1 addition & 1 deletion packages/labs/gen-wrapper-angular/package.json
Expand Up @@ -53,7 +53,7 @@
"dependencies": {
"@lit-labs/analyzer": "^0.2.0",
"@lit-labs/gen-utils": "^0.0.1",
"tests": "0.0.0"
"@lit-internal/tests": "0.0.0"
},
"devDependencies": {
"@esm-bundle/chai": "^4.1.5",
Expand Down
Expand Up @@ -17,7 +17,7 @@ import {
} from '@lit-labs/gen-utils/lib/package-utils.js';
import {writeFileTree} from '@lit-labs/gen-utils/lib/file-utils.js';
import {generateAngularWrapper} from '../../index.js';
import {assertGoldensMatch} from 'tests/utils/assert-goldens.js';
import {assertGoldensMatch} from '@lit-internal/tests/utils/assert-goldens.js';

const testProjects = '../test-projects';
const outputFolder = 'gen-output';
Expand Down
4 changes: 2 additions & 2 deletions packages/labs/gen-wrapper-react/package.json
Expand Up @@ -60,11 +60,11 @@
"dependencies": {
"@lit-labs/analyzer": "^0.2.0",
"@lit-labs/gen-utils": "^0.0.1",
"tests": "0.0.0"
"@lit-internal/tests": "0.0.0"
},
"devDependencies": {
"@types/node": "^17.0.31",
"tests": "^0.0.0",
"@lit-internal/tests": "^0.0.0",
"typescript": "~4.6.2",
"uvu": "^0.5.3"
},
Expand Down
Expand Up @@ -18,7 +18,7 @@ import {
} from '@lit-labs/gen-utils/lib/package-utils.js';
import {writeFileTree} from '@lit-labs/gen-utils/lib/file-utils.js';
import {generateReactWrapper} from '../index.js';
import {assertGoldensMatch} from 'tests/utils/assert-goldens.js';
import {assertGoldensMatch} from '@lit-internal/tests/utils/assert-goldens.js';

const testProjects = '../test-projects';
const outputFolder = 'gen-output';
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/gen-wrapper-vue/package.json
Expand Up @@ -65,7 +65,7 @@
},
"devDependencies": {
"@types/node": "^17.0.31",
"tests": "^0.0.0",
"@lit-internal/tests": "^0.0.0",
"typescript": "^4.6.4",
"uvu": "^0.5.3"
},
Expand Down
Expand Up @@ -18,7 +18,7 @@ import {
} from '@lit-labs/gen-utils/lib/package-utils.js';
import {writeFileTree} from '@lit-labs/gen-utils/lib/file-utils.js';
import {generateVueWrapper} from '../index.js';
import {assertGoldensMatch} from 'tests/utils/assert-goldens.js';
import {assertGoldensMatch} from '@lit-internal/tests/utils/assert-goldens.js';

const testProjects = '../test-projects';
const outputFolder = 'gen-output';
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/motion/package.json
Expand Up @@ -147,7 +147,7 @@
"@web/dev-server": "^0.1.22",
"chokidar-cli": "^3.0.0",
"concurrently": "^6.2.1",
"internal-scripts": "^1.0.0",
"@lit-internal/scripts": "^1.0.0",
"mocha": "^9.1.1",
"rollup": "^2.70.2",
"typescript": "^4.3.5"
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/observers/package.json
Expand Up @@ -159,7 +159,7 @@
"mocha": "^9.1.1",
"rollup": "^2.70.2",
"typescript": "^4.3.5",
"internal-scripts": "^1.0.0"
"@lit-internal/scripts": "^1.0.0"
},
"dependencies": {
"@lit/reactive-element": "^1.1.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/react/package.json
Expand Up @@ -145,7 +145,7 @@
"@web/test-runner-mocha": "^0.7.4",
"chokidar-cli": "^3.0.0",
"concurrently": "^6.2.1",
"internal-scripts": "^1.0.0",
"@lit-internal/scripts": "^1.0.0",
"mocha": "^9.1.1",
"react": "^17.0.1",
"react-dom": "^17.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/router/package.json
Expand Up @@ -151,7 +151,7 @@
"@web/test-runner-mocha": "^0.7.4",
"chokidar-cli": "^3.0.0",
"concurrently": "^6.2.1",
"internal-scripts": "^1.0.0",
"@lit-internal/scripts": "^1.0.0",
"mocha": "^9.1.1",
"rollup": "^2.70.2",
"typescript": "^4.3.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/scoped-registry-mixin/package.json
Expand Up @@ -149,7 +149,7 @@
"mocha": "^9.1.1",
"rollup": "^2.70.2",
"typescript": "^4.3.5",
"internal-scripts": "^1.0.0"
"@lit-internal/scripts": "^1.0.0"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/ssr-client/package.json
Expand Up @@ -95,7 +95,7 @@
"devDependencies": {
"rollup": "^2.70.2",
"typescript": "^4.3.5",
"internal-scripts": "^1.0.0"
"@lit-internal/scripts": "^1.0.0"
},
"dependencies": {
"lit": "^2.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/task/package.json
Expand Up @@ -141,7 +141,7 @@
"mocha": "^9.1.1",
"rollup": "^2.70.2",
"typescript": "^4.3.5",
"internal-scripts": "^1.0.0"
"@lit-internal/scripts": "^1.0.0"
},
"dependencies": {
"@lit/reactive-element": "^1.1.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/labs/vue-utils/package.json
Expand Up @@ -109,7 +109,7 @@
"@web/test-runner-mocha": "^0.7.4",
"chokidar-cli": "^3.0.0",
"concurrently": "^6.2.1",
"internal-scripts": "^1.0.0",
"@lit-internal/scripts": "^1.0.0",
"mocha": "^9.1.1",
"rollup": "^2.70.2",
"typescript": "^4.3.5"
Expand Down
2 changes: 1 addition & 1 deletion packages/lit-element/package.json
Expand Up @@ -224,7 +224,7 @@
"@webcomponents/webcomponentsjs": "^2.6.0",
"chokidar-cli": "^3.0.0",
"downlevel-dts": "^0.7.0",
"internal-scripts": "^1.0.0",
"@lit-internal/scripts": "^1.0.0",
"mocha": "^9.1.1",
"rollup": "^2.70.2",
"tslib": "^2.0.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/lit-html/package.json
Expand Up @@ -284,7 +284,7 @@
"@webcomponents/webcomponentsjs": "^2.6.0",
"chokidar-cli": "^3.0.0",
"concurrently": "^6.2.1",
"internal-scripts": "^1.0.0",
"@lit-internal/scripts": "^1.0.0",
"mocha": "^9.1.1",
"rollup": "^2.70.2",
"typescript": "^4.3.5"
Expand Down
2 changes: 1 addition & 1 deletion packages/lit/package.json
Expand Up @@ -283,7 +283,7 @@
"@webcomponents/webcomponentsjs": "^2.6.0",
"chokidar-cli": "^3.0.0",
"downlevel-dts": "^0.7.0",
"internal-scripts": "^1.0.0",
"@lit-internal/scripts": "^1.0.0",
"mocha": "^9.1.1",
"rollup": "^2.70.2",
"tslib": "^2.0.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/localize-tools/package.json
Expand Up @@ -149,7 +149,7 @@
"@types/parse5": "^6.0.1",
"@types/prettier": "^2.0.1",
"rimraf": "^3.0.2",
"tests": "0.0.0",
"@lit-internal/tests": "0.0.0",
"typescript-json-schema": "^0.50.0",
"uvu": "^0.5.1"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/localize-tools/src/tests/e2e/e2e-goldens-test.ts
Expand Up @@ -13,7 +13,7 @@ import fsExtra from 'fs-extra';
import {dirname} from 'path';
import {fileURLToPath} from 'url';

import {assertGoldensMatch} from 'tests/utils/assert-goldens.js';
import {assertGoldensMatch} from '@lit-internal/tests/utils/assert-goldens.js';

/**
* Run lit-localize end-to-end using input and golden files from the filesystem.
Expand Down
2 changes: 1 addition & 1 deletion packages/localize/examples/runtime-js/CHANGELOG.md
@@ -1,4 +1,4 @@
# lit-localize-examples-runtime-js
# @lit-internal/localize-examples-runtime-js

## 1.0.1
### Patch Changes
Expand Down
4 changes: 2 additions & 2 deletions packages/localize/examples/runtime-js/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/localize/examples/runtime-js/package.json
@@ -1,5 +1,5 @@
{
"name": "lit-localize-examples-runtime-js",
"name": "@lit-internal/localize-examples-runtime-js",
"description": "Example of using lit-localize in runtime mode with JavaScript",
"version": "1.0.1",
"private": true,
Expand Down
2 changes: 1 addition & 1 deletion packages/localize/examples/runtime-ts/CHANGELOG.md
@@ -1,4 +1,4 @@
# lit-localize-examples-runtime-ts
# @lit-internal/localize-examples-runtime-ts

## 1.0.1
### Patch Changes
Expand Down
4 changes: 2 additions & 2 deletions packages/localize/examples/runtime-ts/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/localize/examples/runtime-ts/package.json
@@ -1,5 +1,5 @@
{
"name": "lit-localize-examples-runtime-ts",
"name": "@lit-internal/localize-examples-runtime-ts",
"description": "Example of using lit-localize in runtime mode with TypeScript",
"version": "1.0.1",
"private": true,
Expand Down
2 changes: 1 addition & 1 deletion packages/localize/examples/transform-js/CHANGELOG.md
@@ -1,4 +1,4 @@
# lit-localize-examples-transform-js
# @lit-internal/localize-examples-transform-js

## 1.0.1
### Patch Changes
Expand Down

0 comments on commit e088732

Please sign in to comment.