Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bundling/minification recommendations #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

welingtonms
Copy link

Solves lit.dev's #1161

  • Inform developers that the terser configuration is targeting the docs static site generation
  • Refer to the Lit site for best practices on publishing Web Components and applications that include them.

@google-cla
Copy link

google-cla bot commented Aug 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

* Inform developers that the `terser` configuration is targeting the docs static site generation
* Refer to the Lit site for best practices on publishing Web Components and applications that include them.
@AndrewJakubowicz
Copy link
Contributor

Hi! Thanks for the pull request! The changes look great to me!

Unfortunately, the starter kit files are copied out of the main lit/lit repo from the packages subdirectory.
Would you be able to submit this PR to https://github.com/lit/lit modifying the files there: https://github.com/lit/lit/tree/main/packages/lit-starter-js

I think if this change is submitted here, then there is a risk in the future of the original README undoing your work.

@welingtonms
Copy link
Author

Hi, @AndrewJakubowicz, thanks for letting me know about that!

Just opened the PR there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants