Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update top-level yarn.lock to fix publish fail #100

Merged
merged 1 commit into from Nov 21, 2020
Merged

Update top-level yarn.lock to fix publish fail #100

merged 1 commit into from Nov 21, 2020

Conversation

xiniria
Copy link
Contributor

@xiniria xiniria commented Nov 21, 2020

Description

Run yarn install to update yarn.lock and fix the CI publish fail.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

Fixes the publish problem after issue #99.

Motivation and Context

This change is required to publish a newer version of the package.

How Has This Been Tested?

npm run lint and npm run test passed in both sub-packages.

Checklist:

  • N/A I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • N/A I have added tests to cover my changes.
  • All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

cute-bear

@lirantal
Copy link
Owner

Thanks! Let's see if this gets the deploy stage passing.

@lirantal lirantal merged commit ffe3192 into lirantal:master Nov 21, 2020
@xiniria
Copy link
Contributor Author

xiniria commented Nov 21, 2020

The TravisCI job passed but the version wasn't actually published, as per the job logs 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants