CORE-931: addColumn should support not-null constraint with an initia…

[RG9]

Liquibase generates invalid SQL on addColumn changesets specified with a not-nullable column. The bug manifests when update is executed against a table that is populated with data. Bug is reproducible in 4.6.0.

Steps to Reproduce

• See https://liquibase.jira.com/browse/CORE-931

Dev Notes

nvoxland this pull request should resolve JIRA ticket https://liquibase.jira.com/browse/CORE-931

Test Requirements (Internal Liquibase QA)

This test requires a Postgres instance; version does not matter. The test-harness will execute the test against the following versions: 9, 9.5, 10, 11, 12, 13. The attached changelog includes a changeset that replicates the bug as well as a changeset that was the workaround to the bug prior to the fix; we want to make sure both versions of adding a not-nullable constraint both work after the fix.

Manual Tests

Verify liquibase updatesql generates valid SQL for an addColumn with a notnullable constraint.

liquibase update-sql --changelog-file lb45-changelog.xml

• Generated SQL for the changeset 2::addColumn is:
  ALTER TABLE lb45 ALTER COLUMN "columnWithInitialValue" SET NOT NULL;
• Generated SQL for the changeset 3::addColumnAndAddNotNullConstraint is:
  ALTER TABLE lb45 ALTER COLUMN "columnWithConstraintInSeparateChange" SET NOT NULL;

Verify update is successful for adding a column with a not-nullable constraint on a populated table.

liquibase update --changelog-file lb45-changelog.xml

• There is no error that column "columnWithInitialValue" contains null values.
• Column is added to the table lb45.

Automated Tests

• No new functional automated tests required.
• A liquibase/liquibase-test-harness test is required.
  • Add an XML changelog with the following changesets included in the manual test changelog.
    • 1::createTable
    • 1::insertData
    • 2::addColumn
    • liquibase-test-harness/src/main/resources/liquibase/harness/change/changelogs/postgresql.
  • Add the JSON snapshot for test validation:
    • src/main/resources/liquibase/harness/change/expectedSnapshot/
      • You only need to validate the JSON for the changeset 2::addColumn
  • Add the generated SQL for test validation:
    • src/main/resources/liquibase/harness/change/expectedSql/
      • You only need to validate the SQL for the changeset 2::addColumn
  • Validate that a column with a not-nullable constraint can be added to a populated Postgres table.

┆Issue is synchronized with this Jira Bug by Unito

[ro-rah]

Hi @RG9 !

Thanks for your pull request!

Here’s what happens next:

A member of the Liquibase team will take a look at your contribution and may suggest
changes, additional tests, or provide other feedback. The PR will be prioritized
according to our internal development and testing capacity.

We’ll let you know when it’s ready to move to the next step or if any changes are needed.

-Ronak

[ro-rah]

Labeled Risk Low because unit tests added. Moving to Conditioning internally.

[StevenMassaro]

@RG9 I'm going to update your fork with the latest changes from liquibase/master and resolve the merge conflict.

[sync-by-unito]

➤ Steven Massaro commented:

Surya Aki Erzsebet Carmean Nathan Voxland This change looks to be dev complete to me. It is ready for QA sizing.