Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoreLines command in formatted sql log #877

Merged
merged 3 commits into from Jul 8, 2019
Merged

Conversation

li-on
Copy link
Contributor

@li-on li-on commented Apr 15, 2019

Added ability to ignore some lines in formatted SQL.
Now it's posible to leave commands not supported by liquibase but required by other software - like
SQLPLus.

Example:

--liquibase formatted sql logicalFilePath:st
--changeset test:1
CREATE OR REPLACE PACKAGE test as
END	test;
--ignoreLines:1
/
--changeset test:2
CREATE OR REPLACE PACKAGE BODY test as
END	test;
--ignoreLines:1
/

@nvoxland
Copy link
Contributor

I like the idea, but worry that a count like that will be easy to accidentally break. Would it be better to have
something like --ignore:start and --ignore-end blocks?

--ignoreLines:start
--ignoreLines:end
@li-on
Copy link
Contributor Author

li-on commented Jun 24, 2019

Reason for count was: less typing = more free time :D
But start-end may be better.
I've added support for syntax:
--ignoreLines:start
--ignoreLines:end

Feel free to modify/remove code as you like.

@nvoxland
Copy link
Contributor

nvoxland commented Jul 8, 2019

Both options are always nicer! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants