Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAT-17501] BigQuerry. Support Primary Key #5886

Merged
merged 15 commits into from May 23, 2024
Merged

[DAT-17501] BigQuerry. Support Primary Key #5886

merged 15 commits into from May 23, 2024

Conversation

vitaliimak
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@filipelautert filipelautert self-requested a review May 9, 2024 11:33
KushnirykOleh
KushnirykOleh reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@KushnirykOleh KushnirykOleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think BigQueryAddPrimaryKeyConstraintGeneratorTest should fail as it waits for SELECT 1

@vitaliimak vitaliimak requested a deployment to internal May 22, 2024 09:19 — with GitHub Actions Abandoned
@filipelautert filipelautert merged commit 9313a50 into DAT-17482 May 23, 2024
30 of 32 checks passed
@filipelautert filipelautert deleted the DAT-17501 branch May 23, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KushnirykOleh KushnirykOleh KushnirykOleh approved these changes

@filipelautert filipelautert filipelautert approved these changes

Assignees
No one assigned
Labels
TypeEnhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vitaliimak @KushnirykOleh @filipelautert